Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin/Unpin functionality #585

Merged
merged 2 commits into from
Aug 26, 2015
Merged

Pin/Unpin functionality #585

merged 2 commits into from
Aug 26, 2015

Conversation

geekgonecrazy
Copy link
Contributor

I'm a bit of a meteor noob.. Ok total noob. But here is my attempt to add pin/unpin functionality.

This would add the fields pts and pinned to the messages.

pts being pinned time stamp. This is needed to allow grabbing subsets of pinned as well as displaying when message was pinned.

Related to #310

I don't have all i18n files updated either.

@rodrigok
Copy link
Member

Looks really awesome, you are not so crazy after all 😸

rodrigok added a commit that referenced this pull request Aug 26, 2015
@rodrigok rodrigok merged commit 5b49590 into RocketChat:master Aug 26, 2015
@geekgonecrazy
Copy link
Contributor Author

Lol! This is debatable!

@rodrigok
Copy link
Member

Just waiting for the interface implementation.

@geekgonecrazy
Copy link
Contributor Author

Soon as the tab system is figured out and the UI respect of edit/delete/pin that should be pretty easy

@marceloschmidt
Copy link
Member

Tab system is ready. @geekgonecrazy are you working on this implementation, os shall I pick up from where you left?

@geekgonecrazy
Copy link
Contributor Author

@marceloschmidt if you want to pick up on that feel free. Heh i've got so many different pieces up in the air.

@marceloschmidt
Copy link
Member

I'll do it ;) thanks

@marceloschmidt
Copy link
Member

@geekgonecrazy As per your implementation, one should only be able to pin their own messages? I'm not sure that is really useful... I think there are two alternative implementations for this:

  1. Users can pin anyone's message and the pinned messages will appear for that user only.
  2. Admins can pin anyone's message and those messages are displayed for everybody in the channel.

@RocketChat/owners what do you think?

@geekgonecrazy
Copy link
Contributor Author

That's pretty much how I was thinking. Admins / future moderators / channel creator can pin channel wide.

I was kinda thinking it might be broken up pins for this behavior and staring being at the individual level

@sampaiodiego
Copy link
Member

I think pinned messages should be global.. only admins can do it..

if you (normal user) wants to "save" a message, you should star it! or some another term for that.. but it should be two different commands to not confuse people.

@graywolf336
Copy link
Contributor

I think anyone in the channel should be able to pin messages - for small teams there isn't a need to add complexity. So, maybe this needs to be configurable instead of just one set way.

@geekgonecrazy
Copy link
Contributor Author

Yeah I agree small teams I can see this being useful for pinning links etc during research phase and want others to be able to access it

@sampaiodiego
Copy link
Member

yeah.. it should be configurable..

but I think that you should pin everyone's messages and it will be always visible pinned to everyone. like @marceloschmidt said on second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants